Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFSD Resprite #1064

Merged
merged 32 commits into from
Mar 29, 2024
Merged

NFSD Resprite #1064

merged 32 commits into from
Mar 29, 2024

Conversation

Salvantrix
Copy link
Contributor

@Salvantrix Salvantrix commented Feb 27, 2024

About the PR

NFSD Respirtes, revamped all aspect of NFSD and how they're lookin'.

Still a WIP, only thinG left to add is the on-spawn loadouts.

Why / Balance

Technical details

Mostly completed, just need to finish updating spawn-in loadouts.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image

Breaking changes

Changelog

Copy link
Contributor

github-actions bot commented Feb 27, 2024

RSI Diff Bot; head commit 70e5021 merging into 9504e7e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Back/Backpacks/nfsd_backpack.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Backpacks/nfsd_brigmed_backpack.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Duffels/nfsd_brigmed_duffle.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Duffels/nfsd_duffle.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Satchels/nfsd_brigmed_satchel.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Satchels/nfsd_satchel.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Belt/nfsd_belt.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Belt/nfsd_webbing.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Ears/Headsets/nfsd_e_brown.rsi

State Old New Status
equipped-EARS Added
icon Added
icon_alt Added

Resources/Textures/_NF/Clothing/Ears/Headsets/nfsd_e_cb.rsi

State Old New Status
equipped-EARS Added
icon Added
icon_alt Added

Resources/Textures/_NF/Clothing/Ears/Headsets/nfsd_e_green.rsi

State Old New Status
equipped-EARS Added
icon Added
icon_alt Added

Resources/Textures/_NF/Clothing/Ears/Headsets/nfsd_h_brown.rsi

State Old New Status
alt-equipped-EARS Added
icon_alt Added

Resources/Textures/_NF/Clothing/Ears/Headsets/nfsd_h_cb.rsi

State Old New Status
alt-equipped-EARS Added
icon_alt Added

Resources/Textures/_NF/Clothing/Ears/Headsets/nfsd_h_green.rsi

State Old New Status
alt-equipped-EARS Added
icon_alt Added

Resources/Textures/_NF/Clothing/Eyes/Glasses/nfsd_glasses.rsi

State Old New Status
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Eyes/Hud/nfsd_hud.rsi

State Old New Status
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Hands/Gloves/nfsd_brown.rsi

State Old New Status
equipped-HAND Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Hands/Gloves/nfsd_cream.rsi

State Old New Status
equipped-HAND Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hardsuits/nfsd_helm.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-lizard Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
off-inhand-left Added
off-inhand-right Added
on-equipped-HELMET-lizard Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hardsuits/nfsd_sheriff_helm.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-lizard Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
off-inhand-left Added
off-inhand-right Added
on-equipped-HELMET-lizard Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hats/nfsd_beret_brown.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hats/nfsd_beret_cream.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hats/nfsd_beret_green.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hats/nfsd_campaign.rsi

State Old New Status
equipped-HELMET-vulpkanin Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hats/nfsd_campaign_small.rsi

State Old New Status
equipped-HELMET-vulpkanin Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Neck/Cloaks/nfsdsheriff.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Neck/Mantles/nfsdsheriff.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Scarfs/nfsd_bronze_badge.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Neck/Scarfs/nfsd_gold_badge.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Neck/Scarfs/nfsd_silver_badge.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Neck/Scarfs/nfsd_star_badge.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Armor/nfsd_armor.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/nfsd_brigmed.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/nfsd_bronze.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/nfsd_gold.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/nfsd_sheriff.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/nfsd_silver.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Misc/nfsd_bomber.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Misc/nfsd_brigmed_bomber.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Misc/nfsd_formal.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Misc/nfsd_long.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Misc/nfsd_sheriff_formal.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Shoes/Boots/magboots-nfsd.rsi

State Old New Status
equipped-FEET Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added
on-equipped-FEET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/_NF/Clothing/Shoes/Boots/nfsd_brown_boots.rsi

State Old New Status
equipped-FEET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Shoes/Boots/nfsd_cream_boots.rsi

State Old New Status
equipped-FEET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpskirt/nfsd_skirt.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpskirt/nfsd_skirt_short.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpsuit/nfsd_jump.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpsuit/nfsd_jump_short.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpsuit/nfsd_tac_black.rsi

State Old New Status
equipped-INNERCLOTHING Added

Edit: diff updated after 70e5021

@dvir001 dvir001 marked this pull request as draft February 27, 2024 21:18
@Salvantrix Salvantrix marked this pull request as ready for review February 27, 2024 22:12
@MagnusCrowe
Copy link
Contributor

The blue looks too dark and too saturated.

@CautionDev
Copy link

image

@Kesiath
Copy link
Contributor

Kesiath commented Feb 28, 2024

I think the green would be a better option, as long as it's desaturated enough to not be mistaken with CentCom attire.

dvir001 and others added 7 commits February 28, 2024 21:28
Blue has been thrown out, green updates for everything!
Bingus.
Updated ID's to have actual ID's, Deleted the ID component for badges and they are now vanity scarf items, updated all NFSD starting loadouts, and completed filled variants of all bag items.
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Finishing touches made on NFSD sprites. Ready for review of my spaghet yml.
Added Sheriff Mantle/Cloak.

PR is completed at this stage.
@Cheackraze
Copy link
Member

I wanna bundle this in with the space law changes + server rules changes, etc, and these all look great to me so as soon as conflicts are finished we can merge this.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Mar 12, 2024
@Cheackraze
Copy link
Member

ok something funky is going on with git merge so im going to have to come back to this later this week, sorry about that

@Cheackraze
Copy link
Member

ok I think I fixed it, just ignore the 8 or so commits i had to push hah

@ThatOneGoblin25
Copy link
Contributor

Will this resprite also include airlocks, vendors and nfsd computers?
Or maybe not because then we'll have to redecal every ship...

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Mar 18, 2024
# Conflicts:
#	Resources/Prototypes/_NF/Entities/Clothing/Back/backpacks.yml
#	Resources/Prototypes/_NF/Entities/Clothing/Ears/headsets.yml
#	Resources/Prototypes/_NF/Entities/Clothing/Eyes/hud.yml
#	Resources/Prototypes/_NF/Entities/Clothing/Head/hardsuit-helmets.yml
#	Resources/Prototypes/_NF/Entities/Clothing/OuterClothing/hardsuits.yml
#	Resources/Prototypes/_NF/Entities/Clothing/Uniforms/jumpsuits.yml
#	Resources/Prototypes/_NF/Entities/Objects/Devices/pda.yml
#	Resources/Textures/_NF/Objects/Misc/id_cards.rsi/meta.json
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Mar 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Mar 29, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Mar 29, 2024
@Cheackraze Cheackraze merged commit 7f608c4 into new-frontiers-14:master Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants